Messages in this thread | | | From | Guenter Roeck <> | Date | Mon, 18 Jul 2022 06:33:11 -0700 | Subject | Re: [PATCH v2 08/10] platform/chrome: cros_ec_proto: return -EAGAIN when retries timed out |
| |
On Sun, Jul 17, 2022 at 10:10 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote: > > While EC_COMMS_STATUS_PROCESSING flag is still on after it tries > EC_COMMAND_RETRIES times for sending EC_CMD_GET_COMMS_STATUS, > cros_ec_wait_until_complete() doesn't return an error code. > > Return -EAGAIN in the case instead. > > Signed-off-by: Tzung-Bi Shih <tzungbi@kernel.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> --- > No changes from v1. > > drivers/platform/chrome/cros_ec_proto.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c > index a6ad7f7956e6..9dec475edc84 100644 > --- a/drivers/platform/chrome/cros_ec_proto.c > +++ b/drivers/platform/chrome/cros_ec_proto.c > @@ -167,6 +167,9 @@ static int cros_ec_wait_until_complete(struct cros_ec_device *ec_dev, uint32_t * > return ret; > } > > + if (i >= EC_COMMAND_RETRIES) > + ret = -EAGAIN; > + > return ret; > } > > -- > 2.37.0.170.g444d1eabd0-goog >
| |