lkml.org 
[lkml]   [2022]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [V5,6/8] media: mtk-jpegdec: add output pic reorder interface
From
Il 16/07/22 11:34, Irui Wang ha scritto:
> From: kyrie wu <kyrie.wu@mediatek.com>
>
> add output reorder func to reorder the output images
> to ensure the output pic is consistent with the input images.
>
> Signed-off-by: kyrie wu <kyrie.wu@mediatek.com>
> Signed-off-by: irui wang <irui.wang@mediatek.com>
>
> ---
> .../platform/mediatek/jpeg/mtk_jpeg_dec_hw.c | 49 ++++++++++++++++++-
> 1 file changed, 47 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c
> index 590300108bff..c0468cf96d74 100644
> --- a/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c
> +++ b/drivers/media/platform/mediatek/jpeg/mtk_jpeg_dec_hw.c
> @@ -440,6 +440,51 @@ void mtk_jpeg_dec_set_config(void __iomem *base,
> }
> EXPORT_SYMBOL_GPL(mtk_jpeg_dec_set_config);
>
> +static void mtk_jpegdec_put_buf(struct mtk_jpegdec_comp_dev *jpeg)
> +{
> + struct mtk_jpeg_src_buf *dst_done_buf, *tmp_dst_done_buf;
> + struct vb2_v4l2_buffer *dst_buffer;
> + struct list_head *temp_entry;
> + struct list_head *pos = NULL;
> + struct mtk_jpeg_ctx *ctx;
> + unsigned long flags;
> +
> + ctx = jpeg->hw_param.curr_ctx;
> + if (unlikely(!ctx)) {
> + dev_err(jpeg->dev, "comp_jpeg ctx fail !!!\n");
> + return;
> + }
> +
> + dst_buffer = jpeg->hw_param.dst_buffer;
> + if (!dst_buffer) {
> + dev_err(jpeg->dev, "comp_jpeg dst_buffer fail !!!\n");
> + return;
> + }
> +
> + dst_done_buf = container_of(dst_buffer, struct mtk_jpeg_src_buf, b);
> +
> + spin_lock_irqsave(&ctx->done_queue_lock, flags);
> + list_add_tail(&dst_done_buf->list, &ctx->dst_done_queue);
> + while (!list_empty(&ctx->dst_done_queue) &&
> + (pos != &ctx->dst_done_queue)) {
> + list_for_each_prev_safe(pos,
> + temp_entry,
> + (&ctx->dst_done_queue)) {

This fits in one line, as it results in being 81 columns long, and parenthesis
are redundant for dst_done_queue.

Everything else looks ok to me.

Regards,
Angelo

\
 
 \ /
  Last update: 2022-07-18 12:37    [W:0.244 / U:0.532 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site