Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 18 Jul 2022 09:57:41 +0200 | Subject | Re: [PATCH 2/2] arm64: dts: meson: add support for Beelink GT1 Ultimate | From | Neil Armstrong <> |
| |
On 07/07/2022 11:39, Christian Hewitt wrote: > The Beelink GT1 Ultimate is based on the Amlogic S912 (Q200) > reference design with the following specifications: > > - 3GB DDR3 RAM > - 32GB eMMC > - HDMI 2.1 video > - S/PDIF optical output > - 10/100/1000 Ethernet > - AP6356S Wireless (802.11 a/b/g/n, BT 4.2) > - 3x USB 2.0 ports > - IR receiver > - 1x micro SD card slot > - 1x Power LED (white) > - 1x Reset button (internal) > > Signed-off-by: Christian Hewitt <christianshewitt@gmail.com> > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../dts/amlogic/meson-gxm-gt1-ultimate.dts | 91 +++++++++++++++++++ > 2 files changed, 92 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index 8773211df50e..641399fcbdd9 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -43,6 +43,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-libretech-cc-v2.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-libretech-cc.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-gt1-ultimate.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-khadas-vim2.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-mecool-kiii-pro.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-minix-neo-u9h.dtb > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dts > new file mode 100644 > index 000000000000..2c267884cc16 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-gt1-ultimate.dts > @@ -0,0 +1,91 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) Christian Hewitt <christianshewitt@gmail.com> > + */ > + > +/dts-v1/; > + > +#include "meson-gxm.dtsi" > +#include "meson-gx-p23x-q20x.dtsi" > +#include <dt-bindings/input/input.h> > +#include <dt-bindings/leds/common.h> > + > +/ { > + compatible = "azw,gt1-ultimate", "amlogic,s912", "amlogic,meson-gxm"; > + model = "Beelink GT1 Ultimate"; > + > + leds { > + compatible = "gpio-leds"; > + > + led-white { > + color = <LED_COLOR_ID_WHITE>; > + function = LED_FUNCTION_POWER; > + gpios = <&gpio_ao GPIOAO_9 GPIO_ACTIVE_HIGH>; > + default-state = "on"; > + panic-indicator; > + }; > + }; > + > + adc-keys { > + compatible = "adc-keys"; > + io-channels = <&saradc 0>; > + io-channel-names = "buttons"; > + keyup-threshold-microvolt = <1710000>; > + > + button-function { > + label = "update"; > + linux,code = <KEY_VENDOR>; > + press-threshold-microvolt = <10000>; > + }; > + }; > +}; > + > +ðmac { > + pinctrl-0 = <ð_pins>; > + pinctrl-names = "default"; > + phy-handle = <&external_phy>; > + amlogic,tx-delay-ns = <2>; > + phy-mode = "rgmii"; > +}; > + > +&external_mdio { > + external_phy: ethernet-phy@0 { > + /* Realtek RTL8211F (0x001cc916) */ > + reg = <0>; > + max-speed = <1000>; > + > + reset-assert-us = <10000>; > + reset-deassert-us = <80000>; > + reset-gpios = <&gpio GPIOZ_14 GPIO_ACTIVE_LOW>; > + > + interrupt-parent = <&gpio_intc>; > + /* MAC_INTR on GPIOZ_15 */ > + interrupts = <25 IRQ_TYPE_LEVEL_LOW>; > + }; > +}; > + > +&ir { > + linux,rc-map-name = "rc-beelink-gs1"; > +}; > + > +&sd_emmc_a { > + brcmf: wifi@1 { > + reg = <1>; > + compatible = "brcm,bcm4329-fmac"; > + }; > +}; > + > +&uart_A { > + status = "okay"; > + pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>; > + pinctrl-names = "default"; > + uart-has-rtscts; > + > + bluetooth { > + compatible = "brcm,bcm43438-bt"; > + shutdown-gpios = <&gpio GPIOX_17 GPIO_ACTIVE_HIGH>; > + max-speed = <2000000>; > + clocks = <&wifi32k>; > + clock-names = "lpo"; > + }; > +};
Looks fine for me: Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
| ![\](/images/icornerr.gif) |