lkml.org 
[lkml]   [2022]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 04/49] ALSA: hda/conexant: Fix missing beep setup
    Date
    From: Takashi Iwai <tiwai@suse.de>

    commit 5faa0bc69102f3a4c605581564c367be5eb94dfa upstream.

    Currently the Conexant codec driver sets up the beep NID after calling
    snd_hda_gen_parse_auto_config(). It turned out that this results in
    the insufficient setup for the beep control, as the generic parser
    handles the fake path in snd_hda_gen_parse_auto_config() only if the
    beep_nid is set up beforehand.

    For dealing with the beep widget properly, call cx_auto_parse_beep()
    before snd_hda_gen_parse_auto_config() call.

    Fixes: 51e19ca5f755 ("ALSA: hda/conexant - Clean up beep code")
    Cc: <stable@vger.kernel.org>
    Link: https://bugzilla.kernel.org/show_bug.cgi?id=216152
    Link: https://lore.kernel.org/r/20220620104008.1994-1-tiwai@suse.de
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    sound/pci/hda/patch_conexant.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/sound/pci/hda/patch_conexant.c
    +++ b/sound/pci/hda/patch_conexant.c
    @@ -1061,11 +1061,11 @@ static int patch_conexant_auto(struct hd
    if (err < 0)
    goto error;

    - err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg);
    + err = cx_auto_parse_beep(codec);
    if (err < 0)
    goto error;

    - err = cx_auto_parse_beep(codec);
    + err = snd_hda_gen_parse_auto_config(codec, &spec->gen.autocfg);
    if (err < 0)
    goto error;


    \
     
     \ /
      Last update: 2022-06-30 15:57    [W:3.583 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site