Messages in this thread | | | From | Vincent Guittot <> | Date | Thu, 30 Jun 2022 14:32:23 +0200 | Subject | Re: [PATCH 3/3] thermal/drivers/u8500: Remove the get_trend function |
| |
On Thu, 30 Jun 2022 at 12:16, Daniel Lezcano <daniel.lezcano@linaro.org> wrote: > > On 28/06/2022 14:50, Linus Walleij wrote: > > On Tue, Jun 28, 2022 at 10:40 AM Daniel Lezcano > > <daniel.lezcano@linaro.org> wrote: > > > >> Adding Linus who is missing in the recipient list. > >> > >> > >> On 16/06/2022 22:25, Daniel Lezcano wrote: > >>> The get_trend function relies on the interrupt to set the raising or > >>> dropping trend. However the interpolated temperature is already giving > >>> the temperature information to the thermal framework which is able to > >>> deduce the trend. > >>> > >>> Remove the trend code. > >>> > >>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > > > > I certainly trust you with this :) > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > > > The code was originally written by Hongbo Zhang, but co-developed > > and tested by Vincent Guittot I think, so paging > > him as well. > > Ok, thanks > > If Vincent has no concern with this change, I'll queue up the series
I don't have any particular concerns. I'm just curious, are you planning to remove the get_trend completely from the thermal framework ?
> > > > -- > <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs > > Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | > <http://twitter.com/#!/linaroorg> Twitter | > <http://www.linaro.org/linaro-blog/> Blog
| |