lkml.org 
[lkml]   [2022]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH net-next v9 15/16] ARM: dts: r9a06g032-rzn1d400-db: add switch description
    Hi Clément,

    On Fri, Jun 24, 2022 at 4:42 PM Clément Léger <clement.leger@bootlin.com> wrote:
    > Add description for the switch, GMAC2 and MII converter. With these
    > definitions, the switch port 0 and 1 (MII port 5 and 4) are working on
    > RZ/N1D-DB board.
    >
    > Signed-off-by: Clément Léger <clement.leger@bootlin.com>
    > Reviewed-by: Vladimir Oltean <olteanv@gmail.com>

    Thanks for your patch!

    > --- a/arch/arm/boot/dts/r9a06g032-rzn1d400-db.dts
    > +++ b/arch/arm/boot/dts/r9a06g032-rzn1d400-db.dts
    > @@ -31,3 +33,118 @@ &wdt0 {
    > timeout-sec = <60>;
    > status = "okay";
    > };
    > +
    > +&gmac2 {

    Please keep the nodes sorted (everywhere).

    > +&pinctrl{
    > + pins_mdio1: pins_mdio1 {
    > + pinmux = <
    > + RZN1_PINMUX(152, RZN1_FUNC_MDIO1_SWITCH)
    > + RZN1_PINMUX(153, RZN1_FUNC_MDIO1_SWITCH)
    > + >;

    This is not a single value, but an array of 2 values. Hence they
    should be grouped using angular brackets, to enable automatic
    validation.

    I will fix the above while applying, so no need to resend.

    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
    i.e. will queue in renesas-devel for v5.20.

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2022-06-28 17:36    [W:3.472 / U:0.564 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site