lkml.org 
[lkml]   [2022]   [Jun]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v10 1/3] KVM: s390: ipte lock for SCA access should be contained in KVM
    From


    On 6/24/22 07:47, Janosch Frank wrote:
    > On 6/20/22 14:54, Pierre Morel wrote:
    >> We can check if SIIF is enabled by testing the sclp_info struct
    >> instead of testing the sie control block eca variable.
    >> sclp.has_ssif is the only requirement to set ECA_SII anyway
    >> so we can go straight to the source for that.
    >
    >
    > The subject and commit description don't fit together.
    > You're doing two things in this patch and only describe one of them.
    >
    > I'd suggest something like this:
    >
    > KVM: s390: Cleanup ipte lock access and SIIF facility checks
    >
    > We can check if SIIF is enabled by testing the sclp_info struct instead
    > of testing the sie control block eca variable as that facility is always
    > enabled if available.
    >
    > Also let's cleanup all the ipte related struct member accesses which
    > currently happen by referencing the KVM struct via the VCPU struct.
    > Making the KVM struct the parameter to the ipte_* functions removes one
    > level of indirection which makes the code more readable.
    >

    OK done.


    >
    > Other than that I'm happy with this patch.


    Thanks,

    Pierre



    --
    Pierre Morel
    IBM Lab Boeblingen

    \
     
     \ /
      Last update: 2022-06-27 15:27    [W:2.334 / U:1.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site