Messages in this thread | | | Date | Fri, 24 Jun 2022 14:10:29 +0200 | From | Marcus Folkesson <> | Subject | Re: [PATCH 05/10] dt-bindings: iio: adc: mcp3911: add microchip,data-ready-hiz entry |
| |
On Fri, Jun 24, 2022 at 11:54:58AM +0200, Krzysztof Kozlowski wrote: > > + microchip,data-ready-hiz: > > + description: > > + Data Ready Pin Inactive State Control bit > > "Bit" of what? Do not describe the programming model but the actual feature. >
You are right. I will remove "bit".
> > + true = The DR pin state is high-impedance when data are NOT ready > > + false = The DR pin state is a logic high when data are NOT ready > > + type: boolean > > + default: false > > You do not need default for bools.
OK > > > + > > microchip,device-addr: > > description: Device address when multiple MCP3911 chips are present on the same SPI bus. > > $ref: /schemas/types.yaml#/definitions/uint32 > > > Best regards, > Krzysztof
Thanks, Marcus Folkesson
[unhandled content-type:application/pgp-signature] | |