lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH v2 1/3] mm: Factor out the pagetable pages account into new helper function
    On Wed, Jun 22, 2022 at 04:58:52PM +0800, Baolin Wang wrote:
    > +static inline void pgtable_set_and_inc(struct page *page)
    > +{
    > + __SetPageTable(page);
    > + inc_lruvec_page_state(page, NR_PAGETABLE);
    > +}

    I don't like the names. The accounting is also wrong for non-order-0
    allocations. It should be

    mod_lruvec_page_state(page, NR_PAGETABLE, compound_nr(page))

    but it's probably better to change the API to pass in the number of
    pages instead of recalculating it.

    I can't think of a good name. What's wrong with just adding

    static inline bool pgtable_pud_page_ctor(struct page *page)

    to go along with the pte and pmd variants?

    \
     
     \ /
      Last update: 2022-06-23 18:08    [W:2.475 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site