Messages in this thread | | | From | Doug Anderson <> | Date | Thu, 23 Jun 2022 16:44:52 -0700 | Subject | Re: [PATCH] drm/rockchip: vop: Don't crash for invalid duplicate_state() |
| |
Hi,
On Fri, Jun 17, 2022 at 5:27 PM Brian Norris <briannorris@chromium.org> wrote: > > It's possible for users to try to duplicate the CRTC state even when the > state doesn't exist. drm_atomic_helper_crtc_duplicate_state() (and other > users of __drm_atomic_helper_crtc_duplicate_state()) already guard this > with a WARN_ON() instead of crashing, so let's do that here too. > > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- > > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 +++ > 1 file changed, 3 insertions(+)
I'm not an expert in this area, but it makes sense to me to match drm_atomic_helper_crtc_duplicate_state() in this way. Thus:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
I would tend to assume that this would be landed in drm-misc by Heiko if he's good with it. After several weeks of silence, however, I'll commit it myself.
-Doug
| |