lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 215/234] usb: gadget: lpc32xx_udc: Fix refcount leak in lpc32xx_udc_probe
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    commit 4757c9ade34178b351580133771f510b5ffcf9c8 upstream.

    of_parse_phandle() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not need anymore.
    Add missing of_node_put() to avoid refcount leak.
    of_node_put() will check NULL pointer.

    Fixes: 24a28e428351 ("USB: gadget driver for LPC32xx")
    Cc: stable <stable@kernel.org>
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220603140246.64529-1-linmq006@gmail.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/usb/gadget/udc/lpc32xx_udc.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/usb/gadget/udc/lpc32xx_udc.c
    +++ b/drivers/usb/gadget/udc/lpc32xx_udc.c
    @@ -3021,6 +3021,7 @@ static int lpc32xx_udc_probe(struct plat
    }

    udc->isp1301_i2c_client = isp1301_get_client(isp1301_node);
    + of_node_put(isp1301_node);
    if (!udc->isp1301_i2c_client) {
    retval = -EPROBE_DEFER;
    goto phy_fail;

    \
     
     \ /
      Last update: 2022-06-23 20:22    [W:3.638 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site