lkml.org 
[lkml]   [2022]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 0/2] Kconfig: -O3 enablement
    On Fri, Jun 24, 2022 at 2:00 AM Miko Larsson <mikoxyzzz@gmail.com> wrote:
    >
    > On Thursday, 23 June 2022 17:44:57 CEST Masahiro Yamada wrote:
    > > On Fri, Jun 24, 2022 at 12:42 AM Miko Larsson <mikoxyzzz@gmail.com> wrote:
    > > > On Wednesday, 22 June 2022 03:57:34 CEST Masahiro Yamada wrote:
    > > > > If you want to say "use this option carefully",
    > > > > EXPERT might be another option.
    > > > >
    > > > > depends on ARC || EXPERT
    > > >
    > > > Yeah, this would be a fair compromise, though I think it would be
    > > > better to use "visible if" instead of "depends on". I can get a v2 of
    > > > the series together if this is desired.
    > >
    > > Why is "visible if" better than "depends on"?
    > >
    >
    > Technically it most likely doesn't matter, but logically it makes more
    > sense, since we'd make CC_OPTIMIZE_FOR_PERFORMANCE_O3 be visible if
    > we're on ARC or if we have EXPERT enabled, instead of depending on
    > them. But yeah, it probably doesn't matter.


    Did you write and test the code?


    "visible if" is only supported for "menu".
    This is clearly documented at line 207
    of Documentation/kbuild/kconfig-language.rst


    Using "visible if" for config entry will just
    result in the syntax error.





    > --
    > ~miko
    >
    >
    >


    --
    Best Regards
    Masahiro Yamada

    \
     
     \ /
      Last update: 2022-06-23 20:01    [W:9.114 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site