Messages in this thread | | | Date | Wed, 22 Jun 2022 08:00:37 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH net-next 2/2] net: phy: nxp-tja11xx: use devm_hwmon_sanitize_name() |
| |
On Wed, Jun 22, 2022 at 02:35:43PM +0200, Michael Walle wrote: > Instead of open-coding the bad characters replacement in the hwmon name, > use the new devm_hwmon_sanitize_name(). > > Signed-off-by: Michael Walle <michael@walle.cc>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> --- > drivers/net/phy/nxp-tja11xx.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/phy/nxp-tja11xx.c b/drivers/net/phy/nxp-tja11xx.c > index 9944cc501806..2a8195c50d14 100644 > --- a/drivers/net/phy/nxp-tja11xx.c > +++ b/drivers/net/phy/nxp-tja11xx.c > @@ -444,15 +444,10 @@ static int tja11xx_hwmon_register(struct phy_device *phydev, > struct tja11xx_priv *priv) > { > struct device *dev = &phydev->mdio.dev; > - int i; > - > - priv->hwmon_name = devm_kstrdup(dev, dev_name(dev), GFP_KERNEL); > - if (!priv->hwmon_name) > - return -ENOMEM; > > - for (i = 0; priv->hwmon_name[i]; i++) > - if (hwmon_is_bad_char(priv->hwmon_name[i])) > - priv->hwmon_name[i] = '_'; > + priv->hwmon_name = devm_hwmon_sanitize_name(dev, dev_name(dev)); > + if (IS_ERR(priv->hwmon_name)) > + return PTR_ERR(priv->hwmon_name); > > priv->hwmon_dev = > devm_hwmon_device_register_with_info(dev, priv->hwmon_name, > -- > 2.30.2 >
| |