| Date | Wed, 22 Jun 2022 20:06:57 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 2/8] serial: core, 8250: set RS485 termination gpio in serial core |
| |
On Wed, Jun 22, 2022 at 05:46:53PM +0200, Lino Sanfilippo wrote: > From: Lino Sanfilippo <l.sanfilippo@kunbus.com> > > In serial8250_em485_config() the termination GPIO is set with the uart_port > spinlock held. This is an issue if setting the GPIO line can sleep (e.g. > since the concerning GPIO expander is connected via SPI or I2C). > > Fix this by setting the termination line outside of the uart_port spinlock > in the serial core.
This doesn't describe that this patch is actually changing GPIO to support sleep mode. So, it doesn't fix anything. Please rephrase the commit message accordingly.
> This also makes setting the termination GPIO generic for all uart drivers.
UART
-- With Best Regards, Andy Shevchenko
|