Messages in this thread | | | Date | Wed, 22 Jun 2022 05:47:22 +0200 | From | Oscar Salvador <> | Subject | Re: [PATCH v2 1/2] mm/page_alloc: Do not calculate node's total pages and memmap pages when empty |
| |
On Tue, Jun 21, 2022 at 09:44:47AM +0200, David Hildenbrand wrote: > > > It's worth noting that the check in pgdat_is_empty() is slightly > different. I *think* it doesn't matter in practice, yet I wonder if we > should simply fixup (currently unused) pgdat_is_empty().
I guess we could change it to
static inline bool pgdat_is_empty(pg_data_t *pgdat) { return node_start_pfn(pgdat->node_id) == node_end_pfn(pgdat->node_id) }
? And maybe even rename it to to node_is_empty (not sure why but I tend to like that more than pgdat)
I could squeeze a "fixup" patch for that before this one.
> > Anyhow > > Reviewed-by: David Hildenbrand <david@redhat.com>
Thanks!
-- Oscar Salvador SUSE Labs
| |