lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.18 102/141] comedi: vmk80xx: fix expression for tx buffer size
    Date
    From: Ian Abbott <abbotti@mev.co.uk>

    commit 242439f7e279d86b3f73b5de724bc67b2f8aeb07 upstream.

    The expression for setting the size of the allocated bulk TX buffer
    (`devpriv->usb_tx_buf`) is calling `usb_endpoint_maxp(devpriv->ep_rx)`,
    which is using the wrong endpoint (should be `devpriv->ep_tx`). Fix it.

    Fixes: a23461c47482 ("comedi: vmk80xx: fix transfer-buffer overflow")
    Cc: Johan Hovold <johan@kernel.org>
    Cc: stable@vger.kernel.org # 4.9+
    Reviewed-by: Johan Hovold <johan@kernel.org>
    Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
    Link: https://lore.kernel.org/r/20220607171819.4121-1-abbotti@mev.co.uk
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/comedi/drivers/vmk80xx.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/comedi/drivers/vmk80xx.c
    +++ b/drivers/comedi/drivers/vmk80xx.c
    @@ -684,7 +684,7 @@ static int vmk80xx_alloc_usb_buffers(str
    if (!devpriv->usb_rx_buf)
    return -ENOMEM;

    - size = max(usb_endpoint_maxp(devpriv->ep_rx), MIN_BUF_SIZE);
    + size = max(usb_endpoint_maxp(devpriv->ep_tx), MIN_BUF_SIZE);
    devpriv->usb_tx_buf = kzalloc(size, GFP_KERNEL);
    if (!devpriv->usb_tx_buf)
    return -ENOMEM;

    \
     
     \ /
      Last update: 2022-06-20 15:06    [W:4.053 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site