lkml.org 
[lkml]   [2022]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 140/240] nios2: use fallback for random_get_entropy() instead of zero
    Date
    From: "Jason A. Donenfeld" <Jason@zx2c4.com>

    commit c04e72700f2293013dab40208e809369378f224c upstream.

    In the event that random_get_entropy() can't access a cycle counter or
    similar, falling back to returning 0 is really not the best we can do.
    Instead, at least calling random_get_entropy_fallback() would be
    preferable, because that always needs to return _something_, even
    falling back to jiffies eventually. It's not as though
    random_get_entropy_fallback() is super high precision or guaranteed to
    be entropic, but basically anything that's not zero all the time is
    better than returning zero all the time.

    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Arnd Bergmann <arnd@arndb.de>
    Acked-by: Dinh Nguyen <dinguyen@kernel.org>
    Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    arch/nios2/include/asm/timex.h | 3 +++
    1 file changed, 3 insertions(+)

    --- a/arch/nios2/include/asm/timex.h
    +++ b/arch/nios2/include/asm/timex.h
    @@ -8,5 +8,8 @@
    typedef unsigned long cycles_t;

    extern cycles_t get_cycles(void);
    +#define get_cycles get_cycles
    +
    +#define random_get_entropy() (((unsigned long)get_cycles()) ?: random_get_entropy_fallback())

    #endif

    \
     
     \ /
      Last update: 2022-06-20 15:52    [W:4.046 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site