Messages in this thread | | | Date | Sat, 18 Jun 2022 03:59:26 +0800 | From | kernel test robot <> | Subject | Re: [PATCH v1 2/3] drivers/perf: add DDR Sub-System Driveway PMU driver for Yitian 710 SoC |
| |
Hi Shuai,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on soc/for-next] [also build test WARNING on linus/master v5.19-rc2 next-20220617] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Shuai-Xue/drivers-perf-add-DDR-Sub-System-Driveway-PMU-driver-for-Yitian-710-SoC/20220617-192123 base: https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220618/202206180343.eGENefte-lkp@intel.com/config) compiler: aarch64-linux-gcc (GCC) 11.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/641441c43a62293dd0bae407fda7c229e8689617 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Shuai-Xue/drivers-perf-add-DDR-Sub-System-Driveway-PMU-driver-for-Yitian-710-SoC/20220617-192123 git checkout 641441c43a62293dd0bae407fda7c229e8689617 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/perf/
If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/perf/alibaba_uncore_drw_pmu.c:97:9: warning: no previous prototype for 'ali_drw_pmu_format_show' [-Wmissing-prototypes] 97 | ssize_t ali_drw_pmu_format_show(struct device *dev, | ^~~~~~~~~~~~~~~~~~~~~~~ >> drivers/perf/alibaba_uncore_drw_pmu.c:110:9: warning: no previous prototype for 'ali_drw_pmu_event_show' [-Wmissing-prototypes] 110 | ssize_t ali_drw_pmu_event_show(struct device *dev, | ^~~~~~~~~~~~~~~~~~~~~~
vim +/ali_drw_pmu_format_show +97 drivers/perf/alibaba_uncore_drw_pmu.c
96 > 97 ssize_t ali_drw_pmu_format_show(struct device *dev, 98 struct device_attribute *attr, char *buf) 99 { 100 struct dev_ext_attribute *eattr; 101 102 eattr = container_of(attr, struct dev_ext_attribute, attr); 103 104 return sprintf(buf, "%s\n", (char *)eattr->var); 105 } 106 107 /* 108 * PMU event attributes 109 */ > 110 ssize_t ali_drw_pmu_event_show(struct device *dev, 111 struct device_attribute *attr, char *page) 112 { 113 struct dev_ext_attribute *eattr; 114 115 eattr = container_of(attr, struct dev_ext_attribute, attr); 116 117 return sprintf(page, "config=0x%lx\n", (unsigned long)eattr->var); 118 } 119
-- 0-DAY CI Kernel Test Service https://01.org/lkp
| |