Messages in this thread | | | From | "Verma, Vishal L" <> | Subject | Re: [PATCH 2/3] cxl/mbox: Add GET_POISON_LIST mailbox command support | Date | Thu, 16 Jun 2022 23:44:35 +0000 |
| |
On Thu, 2022-06-16 at 16:15 -0700, Alison Schofield wrote: > On Thu, Jun 16, 2022 at 03:45:25PM -0700, Davidlohr Bueso wrote: > > On Thu, 16 Jun 2022, Alison Schofield wrote: > > > > > cxl list --media-errors -m mem1 > > > lists media errors for requested memdev > > > > > > cxl list --media-errors -r region# > > > > A quick question on the tooling front: the above goes nicely with > > cxl-list, but what about the rest of the poisoning cmds? Do you > > have > > anything in mind? Do we want something specific for media and > > poison > > management instead? Ie: > > > > cxl media --list-errors <params> > Not clear how this one differs. Seems like we can get any piece of > the list w cxl list. > > > cxl media --inject-errors <params> > > cxl media --clear-errors <params> > For inject/clear I'd probably start w what ndctl does today. > ndctl inject−error <namespace> [<options>] > where option -d --uninject performs the clear.
Yeah agreed with Alison that cxl inject-error <options> sounds good. Generally speaking, we've tried to avoid the 'sub-command of a subcommand' situation - such as 'cxl <media> <sub-sub-command> <options>', instead prefering 'cxl <action-object> <options>'.
> > > > > Thanks, > > Davidlohr
| |