lkml.org 
[lkml]   [2022]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH net-next v5 3/5] net: pcs: xpcs: add CL37 1000BASE-X AN support
On Wed, Jun 15, 2022 at 04:39:06PM +0800, Ong Boon Leong wrote:
> For CL37 1000BASE-X AN, DW xPCS does not support C22 method but offers
> C45 vendor-specific MII MMD for programming.
>
> We also add the ability to disable Autoneg (through ethtool for certain
> network switch that supports 1000BASE-X (1000Mbps and Full-Duplex) but
> not Autoneg capability.
>
> v4: Fixes to comment from Russell King. Thanks!
> https://patchwork.kernel.org/comment/24894239/
> Make xpcs_modify_changed() as private, change to use
> mdiodev_modify_changed() for cleaner code.
>
> v3: Fixes to issues spotted by Russell King. Thanks!
> https://patchwork.kernel.org/comment/24890210/
> Use phylink_mii_c22_pcs_decode_state(), remove unnecessary
> interrupt clearing and skip speed & duplex setting if AN
> is enabled.
>
> v2: Fixes to issues spotted by Russell King in v1. Thanks!
> https://patchwork.kernel.org/comment/24826650/
> Use phylink_mii_c22_pcs_encode_advertisement() and implement
> C45 MII ADV handling since IP only support C45 access.
>
> Tested-by: Emilio Riva <emilio.riva@ericsson.com>
> Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

\
 
 \ /
  Last update: 2022-06-15 13:24    [W:0.056 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site