Messages in this thread | | | From | shaozhengchao <> | Subject | 答复: [PATCH bpf-next] samples/bpf: check d etach prog exist or not in xdp fwd | Date | Mon, 9 May 2022 10:27:22 +0000 |
| |
-----邮件原件----- 发件人: Toke Høiland-Jørgensen [mailto:toke@kernel.org] 发送时间: 2022年5月9日 17:46 收件人: shaozhengchao <shaozhengchao@huawei.com>; bpf@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; ast@kernel.org; daniel@iogearbox.net; davem@davemloft.net; kuba@kernel.org; hawk@kernel.org; john.fastabend@gmail.com; andrii@kernel.org; kafai@fb.com; songliubraving@fb.com; yhs@fb.com; kpsingh@kernel.org 抄送: weiyongjun (A) <weiyongjun1@huawei.com>; shaozhengchao <shaozhengchao@huawei.com>; yuehaibing <yuehaibing@huawei.com> 主题: Re: [PATCH bpf-next] samples/bpf: check detach prog exist or not in xdp_fwd
Zhengchao Shao <shaozhengchao@huawei.com> writes:
> Before detach the prog, we should check detach prog exist or not.
If we're adding such a check we should also check that it's the *right* program. I.e., query the ID for the program name and check that it matches what the program attached, then obtain an fd and pass that as XDP_EXPECTED_FD on detach to make sure it wasn't swapped out in the meantime...
-Toke
Thank you for your reply. When finish running xdp_fwd to attatch prog, the program will exit and can't store fd as XDP_EXPECTED_FD.
I think the sample xdp_fwd -d is just detach prog and don't care if the fd is expected.
-zhengchao shao
| |