Messages in this thread | | | Date | Thu, 5 May 2022 10:05:51 -1000 | From | Tejun Heo <> | Subject | Re: [PATCH 5/5] kernfs: Replace global kernfs_open_file_mutex with hashed mutexes. |
| |
On Thu, Apr 28, 2022 at 03:54:31PM +1000, Imran Khan wrote: > +static void __init kernfs_mutex_init(void) > +{ > + int count; > + > + for (count = 0; count < NR_KERNFS_LOCKS; count++) > + mutex_init(&kernfs_locks->open_file_mutex[count]); > +}
Does this need to be a separate function?
> +static void __init kernfs_lock_init(void) > +{ > + kernfs_locks = kmalloc(sizeof(struct kernfs_global_locks), GFP_KERNEL); > + WARN_ON(!kernfs_locks); > + > + kernfs_mutex_init(); > +} > + > void __init kernfs_init(void) > { > kernfs_node_cache = kmem_cache_create("kernfs_node_cache",
Other than that minor nitpick,
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
-- tejun
| |