lkml.org 
[lkml]   [2022]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v4 2/4] mm/migration: remove unneeded lock page and PageMovable check
    From
    On 30.05.22 13:30, Miaohe Lin wrote:
    > When non-lru movable page was freed from under us, __ClearPageMovable must
    > have been done. So we can remove unneeded lock page and PageMovable check
    > here. Also free_pages_prepare() will clear PG_isolated for us, so we can
    > further remove ClearPageIsolated as suggested by David.
    >
    > Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
    > Reviewed-by: Christoph Hellwig <hch@lst.de>
    > Reviewed-by: Oscar Salvador <osalvador@suse.de>
    > ---
    > mm/migrate.c | 9 ++-------
    > 1 file changed, 2 insertions(+), 7 deletions(-)
    >
    > diff --git a/mm/migrate.c b/mm/migrate.c
    > index e88ebb88fa6f..337336115e43 100644
    > --- a/mm/migrate.c
    > +++ b/mm/migrate.c
    > @@ -1090,15 +1090,10 @@ static int unmap_and_move(new_page_t get_new_page,
    > return -ENOSYS;
    >
    > if (page_count(page) == 1) {
    > - /* page was freed from under us. So we are done. */
    > + /* Page was freed from under us. So we are done. */
    > ClearPageActive(page);
    > ClearPageUnevictable(page);
    > - if (unlikely(__PageMovable(page))) {
    > - lock_page(page);
    > - if (!PageMovable(page))
    > - ClearPageIsolated(page);
    > - unlock_page(page);
    > - }
    > + /* free_pages_prepare() will clear PG_isolated. */
    > goto out;
    > }
    >

    Reviewed-by: David Hildenbrand <david@redhat.com>

    --
    Thanks,

    David / dhildenb

    \
     
     \ /
      Last update: 2022-05-31 14:51    [W:8.014 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site