lkml.org 
[lkml]   [2022]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 2/6] mm/vmscan: use node_is_toptier helper in node_reclaim
    Date
    Davidlohr Bueso <dave@stgolabs.net> writes:

    > We have helpers for a reason.
    >
    > Signed-off-by: Davidlohr Bueso <dave@stgolabs.net>
    > ---
    > mm/vmscan.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/mm/vmscan.c b/mm/vmscan.c
    > index 1678802e03e7..cb583fcbf5bf 100644
    > --- a/mm/vmscan.c
    > +++ b/mm/vmscan.c
    > @@ -4750,7 +4750,7 @@ int node_reclaim(struct pglist_data *pgdat, gfp_t gfp_mask, unsigned int order)
    > * over remote processors and spread off node memory allocations
    > * as wide as possible.
    > */
    > - if (node_state(pgdat->node_id, N_CPU) && pgdat->node_id != numa_node_id())
    > + if (node_is_toptier(pgdat->node_id) && pgdat->node_id != numa_node_id())
    > return NODE_RECLAIM_NOSCAN;
    >
    > if (test_and_set_bit(PGDAT_RECLAIM_LOCKED, &pgdat->flags))


    Are we really looking at the top tier in a tiered memory hierarchy here?
    The comment seems to suggest we are looking at local NUMA node?


    -aneesh

    \
     
     \ /
      Last update: 2022-05-31 13:51    [W:5.775 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site