lkml.org 
[lkml]   [2022]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings
    From
    On 31/05/2022 13:27, Puranjay Mohan wrote:
    >>> +examples:
    >>> + - |
    >>> +
    >>> + /* Example k3-am654 base board SR2.0, dual-emac */
    >>> + pruss2_eth: pruss2_eth {
    >>> + compatible = "ti,am654-icssg-prueth";
    >>
    >> Again missed Rob's comment.
    >
    > One of Rob's comment was to make the indentation as 4 which I have done.

    I clearly do not see indentation of 4, but there is 8 instead.

    Let's count:
    + pruss2_eth: pruss2_eth {
    + compatible = "ti,am654-icssg-prueth";
    12345678^

    It's 8...

    >
    > The second comment was about 'ti,prus'.
    >
    > So, ti,prus , firmware-name, and ti,pruss-gp-mux-sel are a part of
    > remoteproc/ti,pru-consumer.yaml which I have included with
    >
    > allOf:
    > - $ref: /schemas/remoteproc/ti,pru-consumer.yaml#
    >
    > So, I thought it is not required to add them again.
    >
    > I will add it in next version, if that is how it should be done.
    I was referring to the indentation.

    Krzysztof

    \
     
     \ /
      Last update: 2022-05-31 13:49    [W:2.419 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site