Messages in this thread | | | Date | Thu, 26 May 2022 22:44:53 +0800 | From | Leo Yan <> | Subject | Re: [PATCH v8 0/4] perf: arm-spe: Decode SPE source and use for perf c2c |
| |
Hi Joe,
On Mon, May 23, 2022 at 01:24:32PM -0400, Joe Mario wrote:
[...]
> Hi Leo: > I figured out why my output was different than yours. > > I did not have the slang-devel rpm installed on the host system. > > In my original perf build, I missed the this output in the build log: > > slang not found, disables TUI support. Please install slang-devel, libslang-dev or libslang2-dev > > Once I installed slang-devel, rebuilt perf, and then reran my test, the pareto output looked fine. > > When the TUI support is disabled, it shouldn't corrupt the resulting stdio output. I don't believe this has anything to do with your commits.
Thanks for taking time to hunt this issue. I checked the code and sent out a patch to fix the stdio interface if slang lib is not installed. Please see the patch:
https://lore.kernel.org/lkml/20220526143917.607928-1-leo.yan@linaro.org/T/#u
> Last, it looks like you should update the help text for the display flag options to reflect your new peer option. > Currently it says: > -d, --display <Switch HITM output type> > lcl,rmt > > But since you added the "peer" display, shouldn't the output for that help text state: > -d, --display <Switch HITM output type> > lcl,rmt,peer
Yeah, will fix.
Very appreciate for your detailed testing and suggestions.
Leo
| |