Messages in this thread | | | Date | Tue, 17 May 2022 13:09:53 +0300 | From | Mika Westerberg <> | Subject | Re: [PATCH v1 1/2] pinctrl: intel: make irq_chip immutable |
| |
On Mon, May 16, 2022 at 09:56:17PM +0300, Andy Shevchenko wrote: > Since recently, the kernel is nagging about mutable irq_chips: > > "not an immutable chip, please consider fixing it!" > > Drop the unneeded copy, flag it as IRQCHIP_IMMUTABLE, add the new > helper functions and call the appropriate gpiolib functions. > > While at it, align IRQ chip callback names with member names for > the sake of consistency.
Or for the sake of inconsistency? ;-) All the other structs are not using this kind of alignment and I would like to keep this one matching the rest too. Also I prefer the format currently used in the driver.
| |