lkml.org 
[lkml]   [2022]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v8 2/8] hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe Tune and Trace device
From
On 17/05/2022 09:09, Yicong Yang wrote:
>>> +    target = cpumask_any(cpumask_of_node(dev_to_node(&hisi_ptt->pdev->dev)));
>>> +    if (target < nr_cpumask_bits) {
>> the comment for cpumask_any() hints to check against nr_cpu_ids - any specific reason to check against nr_cpumask_bits?
>>
> here should be:
> if (target >= nr_cpumask_bits) {
>
> will fix this up.
>

I am still not sure that using nr_cpumask_bits is correct.

\
 
 \ /
  Last update: 2022-05-17 10:22    [W:0.232 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site