Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v6 15/29] x86/hpet: Add helper function hpet_set_comparator_periodic() | Date | Sat, 14 May 2022 10:17:38 +0200 |
| |
On Fri, May 13 2022 at 14:19, Ricardo Neri wrote: > On Fri, May 06, 2022 at 11:41:13PM +0200, Thomas Gleixner wrote: >> The argument about not bloating the code >> with an "obvious???" function which is quite small is slightly beyond my >> comprehension level. > > That obvious function would look like this: > > void hpet_set_comparator_one_shot(int channel, u32 delta) > { > u32 count; > > count = hpet_readl(HPET_COUNTER); > count += delta; > hpet_writel(count, HPET_Tn_CMP(channel)); > }
This function only works reliably when the delta is large. See hpet_clkevt_set_next_event().
Thanks,
tglx
| |