lkml.org 
[lkml]   [2022]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] clk: mediatek: Add MediaTek Helio X10 MT6795 clock drivers
Hi AngeloGioacchino,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on next-20220513]
[cannot apply to clk/clk-next pza/reset/next v5.18-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/AngeloGioacchino-Del-Regno/MediaTek-Helio-X10-MT6795-Clock-drivers/20220514-005314
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220514/202205140634.WJLdMWaS-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/991f92f26cc545a1836a3120408ce27ba7ddadab
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review AngeloGioacchino-Del-Regno/MediaTek-Helio-X10-MT6795-Clock-drivers/20220514-005314
git checkout 991f92f26cc545a1836a3120408ce27ba7ddadab
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/clk/mediatek/clk-mt6795-topckgen.c: In function 'clk_mt6795_topckgen_probe':
>> drivers/clk/mediatek/clk-mt6795-topckgen.c:543:18: error: assignment to 'struct clk_hw_onecell_data *' from incompatible pointer type 'struct clk_onecell_data *' [-Werror=incompatible-pointer-types]
543 | clk_data = mtk_alloc_clk_data(CLK_TOP_NR_CLK);
| ^
>> drivers/clk/mediatek/clk-mt6795-topckgen.c:547:79: error: passing argument 3 of 'mtk_clk_register_fixed_clks' from incompatible pointer type [-Werror=incompatible-pointer-types]
547 | ret = mtk_clk_register_fixed_clks(fixed_clks, ARRAY_SIZE(fixed_clks), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:11:
drivers/clk/mediatek/clk-mtk.h:38:58: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
38 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>> drivers/clk/mediatek/clk-mt6795-topckgen.c:551:72: error: passing argument 3 of 'mtk_clk_register_factors' from incompatible pointer type [-Werror=incompatible-pointer-types]
551 | ret = mtk_clk_register_factors(top_divs, ARRAY_SIZE(top_divs), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:11:
drivers/clk/mediatek/clk-mtk.h:59:55: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
59 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>> drivers/clk/mediatek/clk-mt6795-topckgen.c:556:60: error: passing argument 5 of 'mtk_clk_register_muxes' from incompatible pointer type [-Werror=incompatible-pointer-types]
556 | &mt6795_top_clk_lock, clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:12:
drivers/clk/mediatek/clk-mux.h:87:53: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
87 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>> drivers/clk/mediatek/clk-mt6795-topckgen.c:561:65: error: passing argument 5 of 'mtk_clk_register_composites' from incompatible pointer type [-Werror=incompatible-pointer-types]
561 | &mt6795_top_clk_lock, clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:11:
drivers/clk/mediatek/clk-mtk.h:155:58: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
155 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>> drivers/clk/mediatek/clk-mt6795-topckgen.c:572:79: error: passing argument 3 of 'mtk_clk_unregister_composites' from incompatible pointer type [-Werror=incompatible-pointer-types]
572 | mtk_clk_unregister_composites(top_aud_divs, ARRAY_SIZE(top_aud_divs), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:11:
drivers/clk/mediatek/clk-mtk.h:157:61: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
157 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>> drivers/clk/mediatek/clk-mt6795-topckgen.c:574:68: error: passing argument 3 of 'mtk_clk_unregister_muxes' from incompatible pointer type [-Werror=incompatible-pointer-types]
574 | mtk_clk_unregister_muxes(top_muxes, ARRAY_SIZE(top_muxes), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:12:
drivers/clk/mediatek/clk-mux.h:90:56: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
90 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>> drivers/clk/mediatek/clk-mt6795-topckgen.c:576:68: error: passing argument 3 of 'mtk_clk_unregister_factors' from incompatible pointer type [-Werror=incompatible-pointer-types]
576 | mtk_clk_unregister_factors(top_divs, ARRAY_SIZE(top_divs), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:11:
drivers/clk/mediatek/clk-mtk.h:61:58: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
61 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>> drivers/clk/mediatek/clk-mt6795-topckgen.c:578:75: error: passing argument 3 of 'mtk_clk_unregister_fixed_clks' from incompatible pointer type [-Werror=incompatible-pointer-types]
578 | mtk_clk_unregister_fixed_clks(fixed_clks, ARRAY_SIZE(fixed_clks), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:11:
drivers/clk/mediatek/clk-mtk.h:40:61: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
40 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>> drivers/clk/mediatek/clk-mt6795-topckgen.c:580:27: error: passing argument 1 of 'mtk_free_clk_data' from incompatible pointer type [-Werror=incompatible-pointer-types]
580 | mtk_free_clk_data(clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:11:
drivers/clk/mediatek/clk-mtk.h:188:49: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
188 | void mtk_free_clk_data(struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
drivers/clk/mediatek/clk-mt6795-topckgen.c: In function 'clk_mt6795_topckgen_remove':
drivers/clk/mediatek/clk-mt6795-topckgen.c:590:79: error: passing argument 3 of 'mtk_clk_unregister_composites' from incompatible pointer type [-Werror=incompatible-pointer-types]
590 | mtk_clk_unregister_composites(top_aud_divs, ARRAY_SIZE(top_aud_divs), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:11:
drivers/clk/mediatek/clk-mtk.h:157:61: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
157 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
drivers/clk/mediatek/clk-mt6795-topckgen.c:591:68: error: passing argument 3 of 'mtk_clk_unregister_muxes' from incompatible pointer type [-Werror=incompatible-pointer-types]
591 | mtk_clk_unregister_muxes(top_muxes, ARRAY_SIZE(top_muxes), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:12:
drivers/clk/mediatek/clk-mux.h:90:56: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
90 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
drivers/clk/mediatek/clk-mt6795-topckgen.c:592:68: error: passing argument 3 of 'mtk_clk_unregister_factors' from incompatible pointer type [-Werror=incompatible-pointer-types]
592 | mtk_clk_unregister_factors(top_divs, ARRAY_SIZE(top_divs), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:11:
drivers/clk/mediatek/clk-mtk.h:61:58: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
61 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
drivers/clk/mediatek/clk-mt6795-topckgen.c:593:75: error: passing argument 3 of 'mtk_clk_unregister_fixed_clks' from incompatible pointer type [-Werror=incompatible-pointer-types]
593 | mtk_clk_unregister_fixed_clks(fixed_clks, ARRAY_SIZE(fixed_clks), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:11:
drivers/clk/mediatek/clk-mtk.h:40:61: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
40 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
drivers/clk/mediatek/clk-mt6795-topckgen.c:594:27: error: passing argument 1 of 'mtk_free_clk_data' from incompatible pointer type [-Werror=incompatible-pointer-types]
594 | mtk_free_clk_data(clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-topckgen.c:11:
drivers/clk/mediatek/clk-mtk.h:188:49: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
188 | void mtk_free_clk_data(struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
cc1: some warnings being treated as errors
--
drivers/clk/mediatek/clk-mt6795-mm.c: In function 'clk_mt6795_mm_probe':
>> drivers/clk/mediatek/clk-mt6795-mm.c:86:18: error: assignment to 'struct clk_hw_onecell_data *' from incompatible pointer type 'struct clk_onecell_data *' [-Werror=incompatible-pointer-types]
86 | clk_data = mtk_alloc_clk_data(CLK_MM_NR_CLK);
| ^
>> drivers/clk/mediatek/clk-mt6795-mm.c:90:76: error: passing argument 4 of 'mtk_clk_register_gates' from incompatible pointer type [-Werror=incompatible-pointer-types]
90 | ret = mtk_clk_register_gates(node, mm_gates, ARRAY_SIZE(mm_gates), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-mm.c:10:
drivers/clk/mediatek/clk-gate.h:55:53: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
55 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
cc1: some warnings being treated as errors
--
drivers/clk/mediatek/clk-mt6795-apmixedsys.c: In function 'clk_mt6795_apmixed_probe':
>> drivers/clk/mediatek/clk-mt6795-apmixedsys.c:96:18: error: assignment to 'struct clk_hw_onecell_data *' from incompatible pointer type 'struct clk_onecell_data *' [-Werror=incompatible-pointer-types]
96 | clk_data = mtk_alloc_clk_data(CLK_APMIXED_NR_CLK);
| ^
>> drivers/clk/mediatek/clk-mt6795-apmixedsys.c:100:67: error: passing argument 4 of 'mtk_clk_register_plls' from incompatible pointer type [-Werror=incompatible-pointer-types]
100 | ret = mtk_clk_register_plls(node, plls, ARRAY_SIZE(plls), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-apmixedsys.c:11:
drivers/clk/mediatek/clk-pll.h:53:52: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
53 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>> drivers/clk/mediatek/clk-mt6795-apmixedsys.c:104:12: error: assignment to 'struct clk_hw *' from incompatible pointer type 'struct clk *' [-Werror=incompatible-pointer-types]
104 | hw = mtk_clk_register_ref2usb_tx("ref2usb_tx", "clk26m", base + REG_REF2USB);
| ^
>> drivers/clk/mediatek/clk-mt6795-apmixedsys.c:127:57: error: passing argument 3 of 'mtk_clk_unregister_plls' from incompatible pointer type [-Werror=incompatible-pointer-types]
127 | mtk_clk_unregister_plls(plls, ARRAY_SIZE(plls), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-apmixedsys.c:11:
drivers/clk/mediatek/clk-pll.h:55:55: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
55 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
>> drivers/clk/mediatek/clk-mt6795-apmixedsys.c:129:27: error: passing argument 1 of 'mtk_free_clk_data' from incompatible pointer type [-Werror=incompatible-pointer-types]
129 | mtk_free_clk_data(clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-apmixedsys.c:10:
drivers/clk/mediatek/clk-mtk.h:188:49: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
188 | void mtk_free_clk_data(struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
drivers/clk/mediatek/clk-mt6795-apmixedsys.c: In function 'clk_mt6795_apmixed_remove':
drivers/clk/mediatek/clk-mt6795-apmixedsys.c:140:57: error: passing argument 3 of 'mtk_clk_unregister_plls' from incompatible pointer type [-Werror=incompatible-pointer-types]
140 | mtk_clk_unregister_plls(plls, ARRAY_SIZE(plls), clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-apmixedsys.c:11:
drivers/clk/mediatek/clk-pll.h:55:55: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
55 | struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
drivers/clk/mediatek/clk-mt6795-apmixedsys.c:141:27: error: passing argument 1 of 'mtk_free_clk_data' from incompatible pointer type [-Werror=incompatible-pointer-types]
141 | mtk_free_clk_data(clk_data);
| ^~~~~~~~
| |
| struct clk_hw_onecell_data *
In file included from drivers/clk/mediatek/clk-mt6795-apmixedsys.c:10:
drivers/clk/mediatek/clk-mtk.h:188:49: note: expected 'struct clk_onecell_data *' but argument is of type 'struct clk_hw_onecell_data *'
188 | void mtk_free_clk_data(struct clk_onecell_data *clk_data);
| ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
cc1: some warnings being treated as errors
--
>> drivers/clk/mediatek/clk-mt6795-infracfg.c:14:10: fatal error: reset.h: No such file or directory
14 | #include "reset.h"
| ^~~~~~~~~
compilation terminated.
--
>> drivers/clk/mediatek/clk-mt6795-pericfg.c:13:10: fatal error: reset.h: No such file or directory
13 | #include "reset.h"
| ^~~~~~~~~
compilation terminated.


vim +543 drivers/clk/mediatek/clk-mt6795-topckgen.c

531
532 static int clk_mt6795_topckgen_probe(struct platform_device *pdev)
533 {
534 struct clk_hw_onecell_data *clk_data;
535 struct device_node *node = pdev->dev.of_node;
536 void __iomem *base;
537 int ret;
538
539 base = devm_platform_ioremap_resource(pdev, 0);
540 if (IS_ERR(base))
541 return PTR_ERR(base);
542
> 543 clk_data = mtk_alloc_clk_data(CLK_TOP_NR_CLK);
544 if (!clk_data)
545 return -ENOMEM;
546
> 547 ret = mtk_clk_register_fixed_clks(fixed_clks, ARRAY_SIZE(fixed_clks), clk_data);
548 if (ret)
549 goto free_clk_data;
550
> 551 ret = mtk_clk_register_factors(top_divs, ARRAY_SIZE(top_divs), clk_data);
552 if (ret)
553 goto unregister_fixed_clks;
554
555 ret = mtk_clk_register_muxes(top_muxes, ARRAY_SIZE(top_muxes), node,
> 556 &mt6795_top_clk_lock, clk_data);
557 if (ret)
558 goto unregister_factors;
559
560 ret = mtk_clk_register_composites(top_aud_divs, ARRAY_SIZE(top_aud_divs), base,
> 561 &mt6795_top_clk_lock, clk_data);
562 if (ret)
563 goto unregister_muxes;
564
565 ret = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data);
566 if (ret)
567 goto unregister_composites;
568
569 return 0;
570
571 unregister_composites:
> 572 mtk_clk_unregister_composites(top_aud_divs, ARRAY_SIZE(top_aud_divs), clk_data);
573 unregister_muxes:
> 574 mtk_clk_unregister_muxes(top_muxes, ARRAY_SIZE(top_muxes), clk_data);
575 unregister_factors:
> 576 mtk_clk_unregister_factors(top_divs, ARRAY_SIZE(top_divs), clk_data);
577 unregister_fixed_clks:
> 578 mtk_clk_unregister_fixed_clks(fixed_clks, ARRAY_SIZE(fixed_clks), clk_data);
579 free_clk_data:
> 580 mtk_free_clk_data(clk_data);
581 return ret;
582 }
583

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-05-14 01:04    [W:0.362 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site