Messages in this thread | | | Date | Wed, 11 May 2022 16:53:41 +0200 | From | AngeloGioacchino Del Regno <> | Subject | Re: [PATCH 3/4] iommu/mediatek: Validate number of phandles associated with "mediatek,larbs" |
| |
Il 11/05/22 08:49, Yong Wu ha scritto: > From: Guenter Roeck <groeck@chromium.org> > > Fix the smatch warnings: > drivers/iommu/mtk_iommu.c:878 mtk_iommu_mm_dts_parse() error: uninitialized > symbol 'larbnode'. > > If someone abuse the dtsi node(Don't follow the definition of dt-binding), > for example "mediatek,larbs" is provided as boolean property, the code may > crash. To fix this problem and improve the code safety, add some checking > for the invalid input from dtsi, e.g. checking the larb_nr/larbid valid > range, and avoid "mediatek,larb-id" property conflicts in the smi-larb > nodes. > > Fixes: d2e9a1102cfc ("iommu/mediatek: Contain MM IOMMU flow with the MM TYPE") > Reported-by: kernel test robot <lkp@intel.com> > Reported-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Guenter Roeck <groeck@chromium.org> > Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
| |