Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 8 Apr 2022 20:44:49 +0200 | From | David Sterba <> | Subject | Re: [PATCH] btrfs: zstd: use spin_lock in timer function |
| |
On Sat, Apr 09, 2022 at 02:15:23AM +0800, Schspa Shi wrote: > timer callback was running on bh, and there is no need to disable bh again.
Why do you think so? There was a specific fix fee13fe96529 ("btrfs: correct zstd workspace manager lock to use spin_lock_bh()") that actually added the _bh, so either you need to explain why exactly it's not needed anymore and verify that the reported lockdep warning from the fix does not happen.
| ![\](/images/icornerr.gif) |