Messages in this thread | | | Date | Fri, 8 Apr 2022 14:22:03 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v3] IB/SA: replace usage of found with dedicated list iterator variable |
| |
On Thu, Mar 31, 2022 at 11:16:34AM +0200, Jakob Koschel wrote: > To move the list iterator variable into the list_for_each_entry_*() > macro in the future it should be avoided to use the list iterator > variable after the loop body. > > To *never* use the list iterator variable after the loop it was > concluded to use a separate iterator variable instead of a > found boolean. > > This removes the need to use a found variable and simply checking if > the variable was set, can determine if the break/goto was hit. > > Reviewed-by: Leon Romanovsky <leonro@nvidia.com> > Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com> > > v1->v2: > - set query correctly (Mark Zhang) > > v2->v3: > - remove changelog and link from git commit message (Leon Romanovsky) > > Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ > > drivers/infiniband/core/sa_query.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-)
Applied to for-next, thanks
Jason
| |