Messages in this thread | | | Date | Fri, 8 Apr 2022 10:23:12 +0200 | Subject | Re: [PATCH 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver | From | Javier Martinez Canillas <> |
| |
Hello Neil,
Thanks for your feedback.
On 4/8/22 09:49, Neil Armstrong wrote:
[snip]
>> >> +static struct ssd130x_deviceinfo ssd130x_variants[] = { >> + { >> + .default_vcomh = 0x40, >> + .default_dclk_div = 1, >> + .default_dclk_frq = 5, >> + .page_mode_only = 1, >> + }, > > Why not [SH1106_ID] = { > > and later: > > if (variant < NR_SSD130X_VARIANTS) > ssd130x->device_info = ssd130x_variants[variant]; > > instead of less efficient ssd13x_variant_to_info ? >
Indeed. I'll change that in v2.
-- Best regards,
Javier Martinez Canillas Linux Engineering Red Hat
| |