Messages in this thread | | | Date | Fri, 8 Apr 2022 17:58:36 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v3] staging: rtl8723bs: tidy up error handling |
| |
On Fri, Apr 08, 2022 at 07:44:40AM -0700, Yihao Han wrote: > The check for if rtw_skb_alloc() fails is done twice and is written > in a confusing way. Move the "if (!recvbuf->pskb)" right after > the allocation. The "if (recvbuf->pskb)" check can now be deleted > and the code pulled in one tab. > > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com> > Signed-off-by: Yihao Han <hanyihao@vivo.com> > --- > v2: more extensive cleanup > v3: edit commit message
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards, dan carpenter
| |