Messages in this thread | | | Subject | Re: [kbuild-all] Re: drivers/cxl/pci.c:439:7: warning: Local variable 'rc' shadows outer variable [shadowVariable] | From | "Chen, Rong A" <> | Date | Fri, 8 Apr 2022 11:34:18 +0800 |
| |
On 4/7/2022 8:11 AM, Randy Dunlap wrote: > > > On 4/6/22 04:17, Chen, Rong A wrote: >> >> >> On 4/4/2022 3:29 AM, Randy Dunlap wrote: >>> Hi lkp/ktr, >>> >>> On 4/2/22 04:26, kernel test robot wrote: >>>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master >>>> head: 88e6c0207623874922712e162e25d9dafd39661e >>>> commit: 523e594d9cc03db962c741ce02c8a58aab58a123 cxl/pci: Implement wait for media active >>>> date: 7 weeks ago >>>> compiler: alpha-linux-gcc (GCC) 11.2.0 >>>> >>>> If you fix the issue, kindly add following tag as appropriate >>>> Reported-by: kernel test robot <lkp@intel.com> >>>> >>>> >>>> cppcheck warnings: (new ones prefixed by >>) >>>>>> drivers/cxl/pci.c:439:7: warning: Local variable 'rc' shadows outer variable [shadowVariable] >>>> int rc; >>>> ^ >>>> drivers/cxl/pci.c:431:6: note: Shadowed declaration >>>> int rc, i; >>>> ^ >>>> drivers/cxl/pci.c:439:7: note: Shadow variable >>>> int rc; >>>> ^ >>>> >>>> cppcheck possible warnings: (new ones prefixed by >>, may not real problems) >>>> >>>>>> drivers/cxl/port.c:63:1: warning: There is an unknown macro here somewhere. Configuration is required. If __stringify is a macro then please configure it. [unknownMacro] >>>> MODULE_ALIAS_CXL(CXL_DEVICE_PORT); >>>> ^ >>>> -- >>> >>> Can you provide a cppcheck config file and command line >>> for this, please? >> >> Hi Randy, >> >> The below command can show the warning: >> $ cppcheck --quiet --enable=style,performance,portability --template=gcc drivers/cxl/port.c >> drivers/cxl/port.c:63:1: warning: There is an unknown macro here somewhere. Configuration is required. If __stringify is a macro then please configure it. [unknownMacro] >> MODULE_ALIAS_CXL(CXL_DEVICE_PORT); >> ^ > > Hm, that still shows me nothing. There must be something else. > Maybe it's version-related? I have:
Hi Randy,
I'm using version 2.3:
$ cppcheck --version Cppcheck 2.3
and I can't see the warning too if using Cppcheck 1.86.
Best Regards, Rong Chen
> > $ cppcheck --version > Cppcheck 1.82 > >> >> Best Regards, >> Rong Chen >> >>> >>> My naive testing does not see any of these warnings -- >>> although I can easily spot the problems in the source file. >>> >>> thanks. > > thanks. >
| |