Messages in this thread | ![/](/images/icornerl.gif) | | Date | Thu, 7 Apr 2022 17:24:20 -0400 | From | Nícolas F. R. A. Prado <> | Subject | Re: [v9 2/4] ASoC: mediatek: mt8192: refactor for I2S3 DAI link of speaker |
| |
Hi Jiaxin,
On Wed, Apr 06, 2022 at 06:05:12PM +0800, Jiaxin Yu wrote: > MT8192 platform will use rt1015 or rt1015p codec, so through the > snd_soc_of_get_dai_link_codecs() to complete the configuration > of dai_link's codecs.
Suggestion for the commit message:
As part of the refactoring to allow the same machine driver to be used for the rt1015(p) and rt5682(s) codecs on the MT8192 platform, parse the rt1015(p) codecs from the speaker-codecs property in the devicetree and wire them to the I2S3 backend, instead of hardcoding the links and selecting through the compatible.
> > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com>
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
- Tested on mt8192-asurada-spherion (rt1015p and rt5682). All audio paths still work as previous to this refactor. And it's still possible to omit mediatek,hdmi-codec.
Thanks, Nícolas
| ![\](/images/icornerr.gif) |