Messages in this thread | | | Date | Wed, 6 Apr 2022 14:09:05 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 5.16 0199/1017] PCI: xgene: Revert "PCI: xgene: Fix IB window setup" |
| |
On Tue, Apr 05, 2022 at 11:07:53AM -0600, dann frazier wrote: > On Tue, Apr 5, 2022 at 11:00 AM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > On Tue, Apr 05, 2022 at 09:42:37AM -0600, dann frazier wrote: > > > On Tue, Apr 05, 2022 at 09:18:32AM +0200, Greg Kroah-Hartman wrote: > > > > From: Marc Zyngier <maz@kernel.org> > > > > > > > > commit 825da4e9cec68713fbb02dc6f71fe1bf65fe8050 upstream. > > > > > > > > Commit c7a75d07827a ("PCI: xgene: Fix IB window setup") tried to > > > > fix the damages that 6dce5aa59e0b ("PCI: xgene: Use inbound resources > > > > for setup") caused, but actually didn't improve anything for some > > > > plarforms (at least Mustang and m400 are still broken). > > > > > > > > Given that 6dce5aa59e0b has been reverted, revert this patch as well, > > > > restoring the PCIe support on XGene to its pre-5.5, working state. > > > > > > > > Link: https://lore.kernel.org/r/YjN8pT5e6/8cRohQ@xps13.dannf > > > > Link: https://lore.kernel.org/r/20220321104843.949645-3-maz@kernel.org > > > > Fixes: c7a75d07827a ("PCI: xgene: Fix IB window setup") > > > > Signed-off-by: Marc Zyngier <maz@kernel.org> > > > > Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > > > Cc: stable@vger.kernel.org > > > > Cc: Rob Herring <robh@kernel.org> > > > > Cc: Toan Le <toan@os.amperecomputing.com> > > > > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> > > > > Cc: Krzysztof Wilczyński <kw@linux.com> > > > > Cc: Bjorn Helgaas <bhelgaas@google.com> > > > > Cc: Stéphane Graber <stgraber@ubuntu.com> > > > > Cc: dann frazier <dann.frazier@canonical.com> > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > --- > > > > drivers/pci/controller/pci-xgene.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > Hi Greg, > > > > > > I don't think it makes sense to apply this to 5.10.y, 5.15.y & > > > 5.16.y w/o also applying a backport of 1874b6d7ab1, because without > > > that we will regress support for Stéphane's X-Gene2-based systems. The > > > backport of 1874b6d7ab1 was rejected for these trees because it doesn't > > > apply cleanly, but I've just submitted new versions that do. > > > > Where were those patches sent to? I don't seem to see them on the > > stable list, did I miss them? > > These are the message IDs: > <20220405142505.1268999-1-dann.frazier@canonical.com> > <20220405153419.1330755-1-dann.frazier@canonical.com> > > I've just bounced them directly to you as well. Thanks Greg!
Got them now, vger was being a bit slow due to the onslaught of patches I had sent it.
greg k-h
| |