Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 6 Apr 2022 13:11:53 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH] psi: Fix trigger being fired unexpectedly at initial |
| |
On Fri, Apr 01, 2022 at 09:19:17AM -0700, Suren Baghdasaryan wrote: > On Thu, Mar 31, 2022 at 10:10 PM Hailong Liu > <liuhailong@linux.alibaba.com> wrote: > > > > When a trigger being created, its win.start_value and win.start_time are > > reset to zero. If group->total[PSI_POLL][t->state] has accumulated before, > > this trigger will be fired unexpectedly in the next period, even if its > > growth time does not reach its threshold. > > > > So set the window of the new trigger to the current state value. > > Makes sense to me. Thanks! > > > > > Signed-off-by: Hailong Liu <liuhailong@linux.alibaba.com> > > Acked-by: Suren Baghdasaryan <surenb@google.com>
Thanks!
| ![\](/images/icornerr.gif) |