Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 6 Apr 2022 10:48:03 +0900 | Subject | Re: [PATCH v2 2/2] libata: Inline ata_qc_new_init() in ata_scsi_qc_new() | From | Damien Le Moal <> |
| |
On 4/5/22 14:52, Christoph Hellwig wrote: > On Mon, Apr 04, 2022 at 10:53:10PM +0800, John Garry wrote: >> From: Christoph Hellwig <hch@lst.de> >> >> It is a bit pointless to have ata_qc_new_init() in libata-core.c since it >> pokes scsi internals, so inline it in ata_scsi_qc_new() (in libata-scsi.c). >> >> <Christoph, please provide signed-off-by> >> [jpg, Take Christoph's change from list and form into a patch] >> Signed-off-by: John Garry <john.garry@huawei.com> > > Signed-off-by: Christoph Hellwig <hch@lst.de> > > Although I still think merging the two patches into one to avoid all > the churn would be much better.
I agree. Let's merge these 2 patches.
-- Damien Le Moal Western Digital Research
| ![\](/images/icornerr.gif) |