Messages in this thread | | | Date | Wed, 6 Apr 2022 10:02:11 +0200 | From | Wolfram Sang <> | Subject | Re: [RFC PATCH 08/10] mmc: core: improve API to make clear hw_reset from bus_ops is for cards |
| |
> > To make it unambiguous that bus_ops->hw_reset() is for cards and not for > > controllers, we a) add 'card' to the function name and b) make the > > function argument mmc_card instead of mmc_host. All users are converted, > > too. > > Again b) is sufficient in my opinion. All bus_ops are for cards, while > host_ops are for hosts.
Okay, this argument I buy right away.
> Also, there may be some corner cases where b) can't be done, like the > ->remove() bus_ops for example. In that case, we either have to make > more re-structuring of the code of simply live with that there may be > some special cases.
With the above argument, I could even imaging to simply drop this patch? That keeps 'host' consistently as the default argument? All given that 'bus_ops' are for cards anyway.
[unhandled content-type:application/pgp-signature]
| |