lkml.org 
[lkml]   [2022]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH 08/10] mmc: core: improve API to make clear hw_reset from bus_ops is for cards

> > To make it unambiguous that bus_ops->hw_reset() is for cards and not for
> > controllers, we a) add 'card' to the function name and b) make the
> > function argument mmc_card instead of mmc_host. All users are converted,
> > too.
>
> Again b) is sufficient in my opinion. All bus_ops are for cards, while
> host_ops are for hosts.

Okay, this argument I buy right away.

> Also, there may be some corner cases where b) can't be done, like the
> ->remove() bus_ops for example. In that case, we either have to make
> more re-structuring of the code of simply live with that there may be
> some special cases.

With the above argument, I could even imaging to simply drop this patch?
That keeps 'host' consistently as the default argument? All given that
'bus_ops' are for cards anyway.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-04-06 14:18    [W:0.060 / U:19.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site