Messages in this thread | | | From | <> | Subject | Re: [PATCH v2 2/2] staging: r8188eu: check the return of kzalloc() | Date | Thu, 7 Apr 2022 10:03:49 +0800 |
| |
On Thursday, April 7, 2022 3:22 AM +0800, paskripkin@gmail.com wrote: > > -void rtw_alloc_hwxmits(struct adapter *padapter) > > +s32 rtw_alloc_hwxmits(struct adapter *padapter) > > { > > What about plain 'int'? I know that s32 is typedef for 'int', but 'int' > looks more natural >
I agree with you. Since the type of `_rtw_init_xmit_priv` is `s32`, I directly changed the type of `rtw_alloc_hwxmits` to `s32` (they are neighbors in rtw_xmit.h). In fact, there are many places where `s32` appears together with `int` in related files, so maybe we can leave it as a future work to make all of them a unified form.
Regards, Xiaoke Wang
| |