Messages in this thread | | | Subject | Re: [PATCH] testing/selftests/mqueue: Fix mq_perf_tests to free the allocated cpu set | From | Shuah Khan <> | Date | Wed, 6 Apr 2022 14:05:46 -0600 |
| |
On 4/6/22 11:57 AM, Athira Rajeev wrote: > The selftest "mqueue/mq_perf_tests.c" use CPU_ALLOC to allocate > CPU set. This cpu set is used further in pthread_attr_setaffinity_np > and by pthread_create in the code. But in current code, allocated > cpu set is not freed. Fix this by adding CPU_FREE after its usage > is done. >
Good find.
> Signed-off-by: Athira Rajeev <atrajeev@linux.vnet.ibm.com> > --- > tools/testing/selftests/mqueue/mq_perf_tests.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c b/tools/testing/selftests/mqueue/mq_perf_tests.c > index b019e0b8221c..17c41f216bef 100644 > --- a/tools/testing/selftests/mqueue/mq_perf_tests.c > +++ b/tools/testing/selftests/mqueue/mq_perf_tests.c > @@ -732,6 +732,7 @@ int main(int argc, char *argv[]) > pthread_attr_destroy(&thread_attr); > } > > + CPU_FREE(cpu_set); > if (!continuous_mode) { > pthread_join(cpu_threads[0], &retval); > shutdown((long)retval, "perf_test_thread()", __LINE__); >
CPU_ALLOC() is called very early on in main() and there are a few error paths that exit without calling CPU_FREE. This change doesn't fully fix the problem.
Review the other exit paths where CPU_FREE is needed.
thanks, -- Shuah
| |