lkml.org 
[lkml]   [2022]   [Apr]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] selftest/vm clarify error statement in gup_test
From
Date
On 4/5/22 4:33 PM, Matthew Wilcox wrote:
> On Tue, Apr 05, 2022 at 09:48:09PM +0000, Sidhartha Kumar wrote:
>> - perror("open");
>> - exit(1);
>> + switch (errno) {
>> + case EACCES:
>> + if (getuid())
>> + printf("Please run this test as root\n");
>
> Shouldn't all these be fprintf(stderr, ...); ?
>
>

printf() is consistent with the other messages in this file. Either
works.

thanks,
-- Shuah

\
 
 \ /
  Last update: 2022-04-07 17:28    [W:0.082 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site