Messages in this thread | | | From | "Rafael J. Wysocki" <> | Date | Tue, 5 Apr 2022 20:27:11 +0200 | Subject | Re: [PATCH 1/3] thermal: int340x: Fix bogus acpi_buffer pointer freeing |
| |
On Thu, Mar 24, 2022 at 8:10 PM Davidlohr Bueso <dave@stgolabs.net> wrote: > > It is the caller's responsibility to free only upon ACPI_SUCCESS. > > Signed-off-by: Davidlohr Bueso <dave@stgolabs.net> > --- > drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > index 4954800b9850..0e7931c286ec 100644 > --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c > @@ -186,11 +186,11 @@ static int int3400_thermal_run_osc(acpi_handle handle, char *uuid_str, int *enab > ret = *((u32 *)(context.ret.pointer + 4)); > if (ret != *enable) > result = -EPERM; > + > + kfree(context.ret.pointer); > } else > result = -EPERM; > > - kfree(context.ret.pointer); > - > return result; > } > > --
Because the code before the change is not incorrect, this is a cleanup rather than a fix, so I've adjusted the subject a bit and applied this along with the [2-3/3] as 5.19 material.
Thanks!
| |