Messages in this thread | | | Date | Tue, 5 Apr 2022 11:07:19 +0200 | Subject | Re: [PATCH 1/5] staging: r8188eu: remove HAL_DEF_IS_SUPPORT_ANT_DIV | From | Michael Straube <> |
| |
Hi Greg,
On 4/4/22 16:32, Greg KH wrote: >> +bool support_ant_div(struct adapter *adapter) > > That's a very odd function name to add to the kernel's global namespace > :( > > Pleas emake it more obvious what this is for, with the driver name as > part of the prefix? >
Looking again at this I notice it can be made a static function in rtw_cmd.c.
I'll rework the series and make the function static with a more descriptive name.
thanks, Michael
| |