lkml.org 
[lkml]   [2022]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2] iio:proximity:sx9324: Fix hardware gain read/write
    Quoting Jonathan Cameron (2022-04-02 09:51:31)
    > On Tue, 29 Mar 2022 22:25:31 +0200
    > Stephen Boyd <swboyd@chromium.org> wrote:
    >
    > > Quoting Jonathan Cameron (2022-03-27 07:51:47)
    > > > On Thu, 24 Mar 2022 15:29:28 -0700
    > > > Stephen Boyd <swboyd@chromium.org> wrote:
    > > >
    > > > > There are four possible gain values according to 'sx9324_gain_vals[]':
    > > > >
    > > > > 1, 2, 4, and 8
    > > > >
    > > > > The values are off by one when writing and reading the register. The
    > > > > bits should be set according to this equation:
    > > > >
    > > > > ilog2(<gain>) + 1
    > > > >
    > > > > so that a gain of 8 is 0x3 in the register field and a gain of 4 is 0x2
    > > > > in the register field, etc
    > > >
    > > > Example seems wrong...
    > > >
    > > > ilog2(8) + 1 = 3 + 1 = 0x4
    > > > ilog2(4) + 1 = 2 + 1 = 0x3
    > > > ilog2(2) + 1 = 1 + 1 = 0x2
    > > > ilog2(1) + 1 = 0 + 1 = 0x1
    > > > 0x0 reserved.
    > > >
    > > > or have I misunderstood?
    > >
    > > Nope. I hit the wrong key but your table is correct. Can you fix it when
    > > applying?
    >
    > Done and applied to the fixes-togreg branch of iio.git but I haven't pushed
    > it out yet as I want to rebase that tree on rc1 when it comes out.
    >
    > After that, please take a quick look check I didn't mess up.
    >

    Thanks. Looks good.

    \
     
     \ /
      Last update: 2022-04-05 00:29    [W:5.464 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site