Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 4 Apr 2022 10:31:04 +0100 | From | Will Deacon <> | Subject | Re: [PATCH] locking/refcount: Use REFCOUNT_WARN() to simplify code |
| |
On Wed, Mar 16, 2022 at 08:51:14PM +0800, Zhen Lei wrote: > To avoid the check "new > val" appears twice, and make the style > consistent with that in refcount_warn_saturate(). > > Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> > --- > lib/refcount.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/refcount.c b/lib/refcount.c > index a207a8f22b3ca35..d36aa3fa728f53b 100644 > --- a/lib/refcount.c > +++ b/lib/refcount.c > @@ -84,7 +84,7 @@ bool refcount_dec_not_one(refcount_t *r) > > new = val - 1; > if (new > val) { > - WARN_ONCE(new > val, "refcount_t: underflow; use-after-free.\n"); > + REFCOUNT_WARN("underflow; use-after-free"); > return true; > }
Acked-by: Will Deacon <will@kernel.org>
Will
| ![\](/images/icornerr.gif) |