lkml.org 
[lkml]   [2022]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] staging: r8188eu: Remove goto to no-op exit label
    On Fri, Apr 01, 2022 at 01:41:40PM -0700, Ira Weiny wrote:
    > On Fri, Apr 01, 2022 at 08:35:13PM +0200, Fabio M. De Francesco wrote:
    > > In function rtw_free_netdev() there are two "goto" jumps to a no-op exit
    > > label called "RETURN". Remove the label and return in line.
    >
    > Thanks for the patch! However, A good commit message lists the why and what of
    > a change. I don't see a why for this commit?

    People, stop belly aching about commit messages.

    "Delete no-op goto" is sufficient justification.

    regards,
    dan carpenter

    \
     
     \ /
      Last update: 2022-09-17 16:19    [W:7.332 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site