Messages in this thread | | | Date | Mon, 4 Apr 2022 23:56:56 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 2/3] x86/mce: Define function to extract ErrorAddr from MCA_ADDR |
| |
On Mon, Apr 04, 2022 at 01:55:21PM -0700, Smita Koralahalli wrote: > I didn't quite understand what needs to be moved to mce/internal.h. Was that > addressed to me? The function call smca_extract_err_addr() is in mce/core.c > and the definition in mce.h
In your current v4, the function definition is in arch/x86/kernel/cpu/mce/amd.c
However, since it needs to be inlined into both callsites because mce_read_aux() is marked noinstr, the definition should be
static __always_inline void smca_extract_err_addr(struct mce *m)
and that definition should be in the header mce/internal.h
Thx.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |